Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(all): switch to test package stretchr testify #1006

Merged
merged 1 commit into from
Oct 20, 2023
Merged

test(all): switch to test package stretchr testify #1006

merged 1 commit into from
Oct 20, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Oct 19, 2023 •
edited
Loading

Solved issues and/or description of the change

#960

  • replace gobottest.assert wit assert.Equal by regexp
  • replace gobottest.refute wit assert.NotEqual by regexp
  • make all tests work
  • remove package gobottest

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code for:
    • no productive code is changed
    • no assertion was accidentally removed

@gen2thomas gen2thomas force-pushed the test/switch_to_testify branch 9 times, most recently from ba119ed to 4194c98 Compare October 20, 2023 07:55
@gen2thomas gen2thomas marked this pull request as ready for review October 20, 2023 08:21
@gen2thomas gen2thomas merged commit 3039b2c into hybridgroup:dev Oct 20, 2023
5 checks passed
@gen2thomas gen2thomas deleted the test/switch_to_testify branch October 20, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas